Surface native runner information in the presence of errors, and unconditionally write to reporters. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our TLS certs for tests expired Sept 1, 2023. Create a new set for another year.
Prior to this commit, an ABQ worker that observed a native runner failure would bail with an error, without communicating the native runner's information. This could pose a problem, because if the worker ran any tests, we attempt to write to reporters regardless of whether the worker succeeded or errored. As such, when it is available, make sure to bubble up the native runner information to the reporters, even in error scenarios.
Although the native runner info will be filled in the rwx v1 json reporter whenever possible, as a defensive strategy to avoid bailing out from runs, use the "other" specification if there are cases where the runner info is missing.
ayazhafiz
commented
Sep 27, 2023
Comment on lines
+428
to
+451
| #[derive(Serialize, Deserialize, Clone)] | ||
| struct OtherError { | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| location: Option<Location>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| meta: Option<MetadataMap>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| exception: Option<String>, | ||
| message: String, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| backtrace: Option<Vec<String>>, | ||
| } | ||
|
|
||
| impl OtherError { | ||
| fn from_message(message: String) -> Self { | ||
| Self { | ||
| location: None, | ||
| meta: None, | ||
| exception: None, | ||
| message, | ||
| backtrace: None, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I confirmed captain is able to re-parse the JSON produced by this addition.
kylekthompson
approved these changes
Sep 27, 2023
| "summary": { | ||
| "canceled": 0, | ||
| "failed": 0, | ||
| "otherErrors": 1, | ||
| "otherErrors": 2, |
There was a problem hiding this comment.
or differently stated, we only have one otherError in the list of other errors and I the summary is supposed to reflect those lists (other errors and the tests)
|
Benchmarks:
Fuzz result sizes:
|
ayazhafiz
added a commit
that referenced
this pull request
Sep 27, 2023
As Kyle noted in #76, the calculation of other errors was incorrect. It turns out that we were already recording other native runner errors, but not bubbling them up appropriately to the surface of the rwx v1 json! This makes sure we do so.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Update expired testdata TLS certs
Our TLS certs for tests expired Sept 1, 2023. Create a new set for
another year.
Make sure to communicate native runner info even if tests fail
Prior to this commit, an ABQ worker that observed a native runner
failure would bail with an error, without communicating the native
runner's information. This could pose a problem, because if the worker
ran any tests, we attempt to write to reporters regardless of whether
the worker succeeded or errored. As such, when it is available, make
sure to bubble up the native runner information to the reporters, even
in error scenarios.
Unconditionally use "other" framework if native runner info is missing
Although the native runner info will be filled in the rwx v1 json
reporter whenever possible, as a defensive strategy to avoid bailing out
from runs, use the "other" specification if there are cases where the
runner info is missing.
Report native runner errors as "other errors" in the rwx v1 json reporter