Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report hosted queue errors regardless of token kind #78

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

ayazhafiz
Copy link
Contributor

Prior to this patch, ABQ would fall back to attempting to using an
ephemeral queue if an organization access token was used with the hosted
API and the hosted API returned an unsupported queue error. However, ABQ
should exit unconditionally with the error message in such cases.

A test for abq test and abq report is included.

Prior to this patch, ABQ would fall back to attempting to using an
ephemeral queue if an organization access token was used with the hosted
API and the hosted API returned an unsupported queue error. However, ABQ
should exit unconditionally with the error message in such cases.

A test for `abq test` and `abq report` is included.
@github-actions
Copy link

Bigtest for aacdff9 (run)

Benchmarks:

  • RSpec: 9.47% overhead
    • RSpec time: 17.84 seconds
    • ABQ time: 19.53 seconds
  • RSpec parallel, 10 runs: max 16.14% overhead
    • min 6.73% overhead
    • standard deviation: 3.73%
  • Jest: 5.42% overhead
    • Jest time: 21.57 seconds
    • ABQ time: 22.739 seconds

Fuzz result sizes:

  • PASSED

@ayazhafiz ayazhafiz merged commit e55cc12 into main Oct 20, 2023
17 checks passed
@ayazhafiz ayazhafiz deleted the ayaz/fix-org-token-no-error branch October 20, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants