-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding speed stream #1078
base: minor
Are you sure you want to change the base?
adding speed stream #1078
Conversation
just minor change but needed for adding speed stream parameter to be able to create slider with player speed |
Thanks @wageeh-mankaryos for the PR. I am not yet convinced of the correct approach for this, and the naming is also not consistent with existing streams in the package. Using the current API, you can of course already listen to playbackState.map((state) => state.speed).distinct() Have you tried this? One concern might be the efficiency of it if you are using a slider to control it smoothly, since every fraction that the speed moves it is also broadcasting that to the notification, and you need to test whether the notification bus can cope with events at such a high frequency, but inevitably the speed does need to be reflected here, too. My personal feeling is that |
Replace this paragraph with a description of what this PR is changing or adding, and why.
If there's an open issue your PR is fixing, please list it here.
Pre-launch Checklist
minor
branch OR my change is breaking and lands inmajor
branch.pubspec.yaml
according to the pub versioning philosophy.* DESCRIPTION OF YOUR CHANGE (@your-git-username)
).///
).dart analyze
.dart format
.flutter test
and all tests are passing.