Bugfix glyphnames in released fonts #1758
Merged
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The script is extremely slow. [how] Instead of spawning a new subshell for each glyph (to determine the codepoint of a char), execute the printf within the current shell. Before: ./generate-css.sh 25,06s user 33,26s system 101% cpu 57,414 total After: ./generate-css.sh 1,89s user 0,50s system 102% cpu 2,330 total Signed-off-by: Fini Jastrow <[email protected]>
[why] When the icon sets have changed (added or names changed) the i_*.sh files are (hopefully) up to date, but the glyphnames.json file is only updated on release. Unfortunately the font-patcher uses the glyphnames.json to determine the patched-in glyphs' names, but in the workflow the json file is only updated after all fonts have been patched. [how] Like the version number in the font-patcher file we also create a transient glyphnames.json in each patching job, that the font-patcher can then utilize. Still the in-repo glyphnames.json is only updated after successful release. So in pinciple we call the generate-css.sh (which also generates the glyphnames.json) once for every font in the font matrix (just before patching) and then finally after all patching has been done again and that is committed back to the repo. Fixes: #1745 Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
Update the
glyphnames.jsonin the release workflow before the fonts are patched, because an up-to-date glyphname database is needed for patching.The first commit speeds up the
glyphnames.jsoncreator script which is extremely slow - that has never been tackled because it was only once called after a 3 hour patch run, and so it did not matter match anyhow.How should this be manually tested?
Any background context you can provide?
In the last (
v3.3.0) release this bug has been circumvented manually.What are the relevant tickets (if any)?
Fixes: #1745
Screenshots (if appropriate or helpful)