feature/fix on same line #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ryanpeach
commented
Dec 15, 2024
ryanpeach
commented
- Reproduced error in Having trouble making edits on the same line for UnlinkedText #45
- Wrote the test that fails, needs to pass
- Found another instance that would cause bad highlighting
- Actually these are the right numbers, we are working in bytes not characters
- WIP: Made unlinked text a little more understandable
ryanpeach
force-pushed
the
feature/fix-on-same-line
branch
4 times, most recently
from
65cac00 to
8bf37b3
Compare
ryanpeach
force-pushed
the
feature/fix-on-same-line
branch
from
8bf37b3 to
bc3c54b
Compare
ryanpeach
force-pushed
the
feature/fix-on-same-line
branch
from
d280950 to
08e0c39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.