Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontmatter Upgrade #58

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Frontmatter Upgrade #58

merged 5 commits into from
Dec 17, 2024

Conversation

ryanpeach
Copy link
Owner

No description provided.

@ryanpeach ryanpeach force-pushed the feature/frontmatter-upgrade branch from 702a934 to ca2324e Compare December 17, 2024 07:11
Cargo.toml Outdated
@@ -15,7 +15,7 @@ debug = true
aho-corasick = "1.1.3"
bon = "2.3.0"
clap = { version = "4.5.16", features = ["derive"] }
comrak = "0.29.0"
comrak = "0.31.0"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comrak needs a new release

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kivikakk thanks!

@ryanpeach ryanpeach force-pushed the feature/frontmatter-upgrade branch from 833aff0 to 7e9478c Compare December 17, 2024 11:20
@ryanpeach
Copy link
Owner Author

ryanpeach commented Dec 17, 2024

---
ugds: xlvf, zptqgmbety
---

- lorem lhet qfee trbiuhd bz #dolor
-

"dolor" starts at offset 62 but comrak says 61

@kivikakk @SamWilsn can you confirm RE: kivikakk/comrak#494

@ryanpeach
Copy link
Owner Author

ryanpeach commented Dec 17, 2024

Relevant methods:

NodeValue::WikiLink(NodeWikiLink { url }) => {

@ryanpeach
Copy link
Owner Author

@kivikakk @SamWilsn RE: kivikakk/comrak#494 Sorry, false alarm. Fixed my tests.

@ryanpeach ryanpeach merged commit e237719 into main Dec 17, 2024
1 check passed
@ryanpeach ryanpeach deleted the feature/frontmatter-upgrade branch December 17, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade cormak for better frontmatter support
2 participants