Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the deprecated function #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change the deprecated function #23

wants to merge 2 commits into from

Conversation

BardoQi
Copy link

@BardoQi BardoQi commented Dec 8, 2020

Change the redis deprecated function evaluate to eval

@rybakit
Copy link
Owner

rybakit commented Dec 8, 2020

Funny, because it was initially eval(), but I changed that to evaluate() deliberately because of this: phpredis/phpredis#316. But it seems to be no longer a problem since PHP 7, so it might also be a good idea to drop PHP 5.x support within this change. Also, I'm curious how difficult will it be to fix the CI?

@rybakit rybakit mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BardoQi @rybakit