Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better error reporting #30

Merged
merged 8 commits into from
Nov 21, 2024
Merged

feat: better error reporting #30

merged 8 commits into from
Nov 21, 2024

Conversation

infiniteregrets
Copy link
Member

@infiniteregrets infiniteregrets commented Nov 20, 2024 •
edited
Loading

wip

@infiniteregrets infiniteregrets requested a review from a team as a code owner November 20, 2024 17:28
@infiniteregrets infiniteregrets marked this pull request as draft November 20, 2024 17:28
@infiniteregrets
Copy link
Member Author

Screenshot 2024-11-20 at 12 47 47 PM

@infiniteregrets
Copy link
Member Author

^ this is just a little experiment, quite over complicated

thinking of miette Report instead

@infiniteregrets
Copy link
Member Author

templating is good, but this is a mess, looking at building something similar to https://doc.rust-lang.org/std/io/struct.Error.html

@infiniteregrets infiniteregrets marked this pull request as ready for review November 20, 2024 20:39
vrongmeal
vrongmeal reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really looks way cleaner now. Just some tiny comments.

src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
vrongmeal
vrongmeal approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@infiniteregrets infiniteregrets merged commit 213f4f6 into main Nov 21, 2024
2 checks passed
@infiniteregrets infiniteregrets deleted the error-reporting branch November 21, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrongmeal vrongmeal vrongmeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infiniteregrets @vrongmeal