feat: Stream fence and trim commands
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #33 Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
reviewed
Dec 4, 2024
| @@ -90,7 +94,7 @@ impl std::fmt::Display for ServiceErrorContext { | |||
|
|
|||
| /// Error for holding relevant info from `tonic::Status` | |||
| #[derive(thiserror::Error, Debug, Default)] | |||
| #[error("{status}: \n{message}")] | |||
| #[error("{status}:\n {message}")] | |||
There was a problem hiding this comment.
the space there helps look like an inline, does it mess up with the output
There was a problem hiding this comment.
The space was in the wrong place, this should fix it :)
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
reviewed
Dec 4, 2024
shikhar
reviewed
Dec 4, 2024
| ..Default::default() | ||
| ClientError::Conversion(conv) => Self { | ||
| message: conv.to_string(), | ||
| status: "Failed to convert SDK type".to_string(), |
There was a problem hiding this comment.
Ah I meant to also include the underlying message conv, we shouldn't throw away the context.
There was a problem hiding this comment.
conv is the message here
There was a problem hiding this comment.
oh doh, my original complaint is not valid ;P
shikhar
approved these changes
Dec 4, 2024
Signed-off-by: Vaibhav Rabber <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #33