feat: Speedtest (#48) #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #48 Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
reviewed
Dec 9, 2024
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
reviewed
Dec 9, 2024
|
Let's rename to |
Signed-off-by: Vaibhav Rabber <[email protected]>
|
|
||
| let tail = stream_client.check_tail().await?; | ||
|
|
||
| prepare_progress_bar.finish(); |
There was a problem hiding this comment.
is there a method to remove the progress bar when its done? instead of taking it to 100%
There was a problem hiding this comment.
Yeah, I had this in mind. With the interactivity thing, the lib is going to change so, let's see what happens there.
|
please also refactor into a separate module than |
Shikhar and I just talked about the opposite, going to completely make this interactive like you suggested in the first place. This is going to be |
|
you can reopen a fresh PR with the new approach! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #48