Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support s2:// URIs #74

Merged
merged 7 commits into from
Dec 13, 2024
Merged

feat: Support s2:// URIs #74

merged 7 commits into from
Dec 13, 2024

Conversation

vrongmeal
Copy link
Member

Resolves: #73

@vrongmeal
feat: Support s2:// URLs
40dd4be 
Resolves: #73

Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal requested a review from a team as a code owner December 12, 2024 20:11
@vrongmeal
Copy link
Member Author

This should be it, just need to test it out.

@vrongmeal
clippy
ab6082f 
Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal
Copy link
Member Author

Yup, this should be ready:

❯ s2 ls s2://vr-basin/pingtest
pingtest/express 2024-12-09T19:01:46Z
pingtest/standard 2024-12-09T19:02:18Z

❯ s2 list-streams --prefix 'pingtest/' vr-basin
pingtest/express 2024-12-09T19:01:46Z
pingtest/standard 2024-12-09T19:02:18Z

❯ s2 rm s2://vr-basin/pingtest/standard
✓ Stream deletion requested

❯ s2 get-basin-config s2://vr-basin
{
  "default_stream_config": null
}

@vrongmeal
update sdk
55a2c33 
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
shikhar reviewed Dec 12, 2024
View reviewed changes
src/types.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Dec 12, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
shikhar
shikhar approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@shikhar shikhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

@shikhar shikhar changed the title feat: Support s2:// URLs feat: Support s2:// URIs Dec 12, 2024
infiniteregrets
infiniteregrets reviewed Dec 12, 2024
View reviewed changes
src/types.rs Outdated Show resolved Hide resolved
infiniteregrets
infiniteregrets reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@infiniteregrets infiniteregrets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! can you please update the relevant help sections?

@vrongmeal vrongmeal merged commit 0a50429 into main Dec 13, 2024
3 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/s2-uri branch December 13, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiniteregrets infiniteregrets infiniteregrets left review comments

@shikhar shikhar shikhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s2:// uri support
3 participants
@vrongmeal @shikhar @infiniteregrets