Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor errors to return tonic::Status #57

Merged
merged 4 commits into from
Nov 15, 2024
Merged

chore: refactor errors to return tonic::Status #57

merged 4 commits into from
Nov 15, 2024

Conversation

infiniteregrets
Copy link
Member

No description provided.

@infiniteregrets infiniteregrets requested a review from a team as a code owner November 14, 2024 19:41
shikhar
shikhar reviewed Nov 14, 2024
View reviewed changes
src/types.rs Outdated Show resolved Hide resolved
@shikhar
Copy link
Member

shikhar commented Nov 14, 2024

There are a few more places where we were using ConvertError before and letting caller turn into an encapsulating error, can you restore those?

@infiniteregrets
Copy link
Member Author

There are a few more places where we were using ConvertError before and letting caller turn into an encapsulating error, can you restore those?

Sure! but I think its better to have ServiceError returned? I can move it down where it was originally

@infiniteregrets infiniteregrets merged commit 0d142ee into main Nov 15, 2024
2 checks passed
@infiniteregrets infiniteregrets deleted the error-refactor branch November 15, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikhar shikhar shikhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infiniteregrets @shikhar