fix: Remove ConnectionError in favour of pre-processing
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #60 Signed-off-by: Vaibhav Rabber <[email protected]>
vrongmeal
commented
Nov 19, 2024
Comment on lines
+691
to
+692
| .user_agent(config.user_agent.clone()) | ||
| .unwrap() |
There was a problem hiding this comment.
Unfortunately need to unwrap since the arg is TryInto<HeaderValue> which for HeaderValue would never fail.
There was a problem hiding this comment.
can you switch as many unwrap()s as reasonable to expect() with a very brief message about why it is safe?
There was a problem hiding this comment.
Oops saw this a bit late. Will update.
shikhar
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #60