Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homework solution #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Homework solution #1

wants to merge 3 commits into from

Conversation

sadfuzzy
Copy link
Owner

  • The frontend properly fetches the data, filters are being sent, requests are being sent with debounce every 300ms, non-successful response codes are logged and empty array is used.
  • The backend is taking optimized time and cached result to respond, filters are applied, data returned is limited with CompanySerializer, db performance is optimized with joins.
  • The confidence in our current functionality and ability to deploy additional changes is ok. CompaniesController logic is covered with spec.
  • The confidence in our security posture is enough. Rack attack is used.

@sadfuzzy sadfuzzy force-pushed the homework_solution branch 3 times, most recently from 72d2c28 to 4a9a438 Compare April 24, 2024 13:10
@sadfuzzy sadfuzzy added the enhancement New feature or request label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sadfuzzy