Disable Pre-approved IsValidSignature #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
force-pushed
the
feat/disable-pre-approved-1271-signature
branch
from
9f29682 to
7d96457
Compare
rmeissner
reviewed
Dec 11, 2024
This commit disabes support for pre-approved signatures from `msg.sender` for `isValidSignature` calls. Note that we remove the new 1.5.0-only `checkSignatures` interface in favour of one with `msg.sender` explicitely provided to avoid issues for contracts that make use of this function.
nlordell
force-pushed
the
feat/disable-pre-approved-1271-signature
branch
from
7d96457 to
57bffd6
Compare
nlordell
force-pushed
the
feat/disable-pre-approved-1271-signature
branch
from
aae8171 to
4732e72
Compare
mmv08
approved these changes
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables support for pre-approved signatures from
msg.senderforisValidSignaturecalls.Note that we remove the new 1.5.0-only
checkSignaturesinterface in favour of one withexecutorexplicitly provided to avoid issues for contracts that make use of this function.