Update comments in SignatureVerifierMuxer to reflect correct byte ranges for encodeData and payload lengths #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges for encodeData and payload lengths
sara554-beep
approved these changes
Dec 20, 2024
Jakeshellybase
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes modifying the
SignatureVerifierMuxercontract to correct the byte offsets for encoding and payload data.Changes to byte offsets:
contracts/handler/extensible/SignatureVerifierMuxer.sol: Updated the byte offset ranges forencodeData length,encodeData, andpayload lengthto correct values.