Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in comments #878

Merged
merged 1 commit into from
Jan 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion certora/specs/NativeTokenRefund.spec
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ rule nativeTokenRefundIsSentToRefundReceiver(
// and adding pre-requirements is tricky
// also, it shouldn't be the safe itself
require refundReceiver != 0 && refundReceiver != currentContract;
// // We're being optimistic about the delegatecall and in the munged contracts the actuall call was removed
// // We're being optimistic about the delegatecall and in the munged contracts the actual call was removed
// // So it's possible the gas used to be 0 in the munged contracts, so no refund would be sent (a counterexample)
// require operation == Enum.Operation.Call;

Expand Down
2 changes: 1 addition & 1 deletion tests_deprecated/utils/execution.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ let estimateBaseGas = function(safe, to, value, data, operation, txGasEstimate,
let baseGasEstimate = calcDataGasCosts(payload) + signatureCost + (nonce > 0 ? 5000 : 20000)
baseGasEstimate += 1500 // 1500 -> hash generation costs
baseGasEstimate += 1000 // 1000 -> Event emission
return baseGasEstimate + 32000; // Add aditional gas costs (e.g. base tx costs, transfer costs)
return baseGasEstimate + 32000; // Add additional gas costs (e.g. base tx costs, transfer costs)
}

let executeTransactionWithSigner = async function(signer, safe, subject, accounts, to, value, data, operation, executor, opts) {
Expand Down
Loading