Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various QoL improvments #1311

Merged
merged 13 commits into from
Sep 14, 2023
Merged

Various QoL improvments #1311

merged 13 commits into from
Sep 14, 2023

Conversation

ppacher
Copy link
Contributor

@ppacher ppacher commented Sep 6, 2023

No description provided.

…etimeEncoder to support values specified in seconds
dhaavi
dhaavi previously approved these changes Sep 7, 2023
Copy link
Member

@dhaavi dhaavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

@ppacher ppacher changed the title Add support for $gt, $ge, $lt, $le operators for netquery. Update DatetimeEncoder to support values specified in seconds Various QoL improvments Sep 14, 2023
netquery/query_handler.go Show resolved Hide resolved
netquery/query_handler.go Show resolved Hide resolved
core/config.go Outdated Show resolved Hide resolved
core/config.go Outdated Show resolved Hide resolved
@dhaavi dhaavi merged commit 9e63a94 into develop Sep 14, 2023
4 checks passed
@dhaavi dhaavi deleted the feature/additional-netquery-matchers branch September 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants