Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile icon migration and other fixes #1313

Merged
merged 16 commits into from
Sep 19, 2023
Merged

Conversation

dhaavi
Copy link
Member

@dhaavi dhaavi commented Sep 12, 2023

  • Derive profile ID from fingerprints
  • Migrate profile icons from fields to list of icons
  • Add first method to merge profiles
  • De-duplicate fingerprints and icons
  • Fix error log when no logs exist

@dhaavi dhaavi requested a review from ppacher September 12, 2023 14:39
@dhaavi dhaavi marked this pull request as draft September 12, 2023 14:39
@dhaavi dhaavi force-pushed the feature/profile-sync branch from 1f0da21 to 070a322 Compare September 14, 2023 14:32
@dhaavi dhaavi marked this pull request as ready for review September 19, 2023 14:44
@dhaavi
Copy link
Member Author

dhaavi commented Sep 19, 2023

Linter warnings are just from prepared methods for the next step.

@dhaavi dhaavi changed the title Add profile merging and prepare for sync Add profile icon migration and other fixes Sep 19, 2023
@dhaavi dhaavi merged commit 6ff7c5f into develop Sep 19, 2023
3 of 4 checks passed
@dhaavi dhaavi deleted the feature/profile-sync branch September 19, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant