Add first set of import/export APIs #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppacher
suggested changes
Sep 22, 2023
sync/settings.go
Outdated
Comment on lines
241
to
270
| if checked < len(settings) { | ||
| return nil, fmt.Errorf("%w: the export contains unknown settings", ErrInvalidImport) | ||
| } |
There was a problem hiding this comment.
This will break the plugin system when it eventually get's merged
There was a problem hiding this comment.
I would expect the plugins to be already loaded when settings are imported.
We could however, treat this as a warning instead - but we can also "weaken" this later on.
dhaavi
force-pushed
the
feature/import-export-apis
branch
from
0d1dae2 to
5d4ee71
Compare
dhaavi
force-pushed
the
feature/import-export-apis
branch
from
d43920e to
225c083
Compare
…ribute connections after profile deletion
dhaavi
force-pushed
the
feature/import-export-apis
branch
from
f12ac97 to
bb75b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.