Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @angular/cdk from 16.0.1 to 18.2.1 in /desktop/angular #1665

Closed
wants to merge 1 commit into from
Closed

Bump @angular/cdk from 16.0.1 to 18.2.1 in /desktop/angular #1665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 36 additions & 6 deletions desktop/angular/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion desktop/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"private": true,
"dependencies": {
"@angular/animations": "^16.0.1",
"@angular/cdk": "^16.0.1",
"@angular/cdk": "^18.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update Angular dependencies for compatibility.

The @angular/cdk has been updated to ^18.2.1, but other Angular dependencies remain at ^16.0.1. To ensure compatibility and prevent potential issues, consider updating the other Angular packages to match the CDK version. Thorough testing is also recommended to verify the integration.

Analysis chain

Approve the version update but recommend further actions.

The version bump of @angular/cdk from ^16.0.1 to ^18.2.1 is noted. While this update is likely beneficial, it's crucial to ensure compatibility with other Angular dependencies and to test the application thoroughly to confirm that the new version integrates smoothly without introducing any regressions.

The version change is approved.

Would you like assistance in setting up a testing plan or performing compatibility checks for this update?

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify if other Angular-related dependencies need updates to ensure compatibility with the new CDK version.

# Test: List all Angular-related dependencies and their versions.
grep '@angular/' package.json

Length of output: 75

Script:

#!/bin/bash
# Search for package.json files in the repository to confirm their existence and correct path.
fd package.json

Length of output: 351

Script:

#!/bin/bash
# List all Angular-related dependencies and their versions in the correct package.json file.
grep '@angular/' desktop/angular/package.json

Length of output: 486

"@angular/common": "^16.0.1",
"@angular/compiler": "^16.0.1",
"@angular/core": "^16.0.1",
Expand Down
Loading