Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pkg-config to find msolve, otherwise try to run it #38331

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Jul 2, 2024

spkg-config.m4 for msolve

This will fix #38315

So far, it's not possible to find msolve's version by running it, but it should be fixed in the future by algebraic-solving/msolve#147

📝 Checklist

  • [ x] The title is concise and informative.
  • [ x] The description explains in detail what this PR is about.
  • [ x] I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Jul 2, 2024

Documentation preview for this PR (built with commit 5c875f4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member Author

dimpase commented Jul 3, 2024

there are no dependencies checks in spkg-configure.m4, as we only use an executable which is already self-sufficient.
(it would have to change if we had an library interface to msolve)

@mezzarobba
Copy link
Member

Thank you! Lgtm.

@dimpase
Copy link
Member Author

dimpase commented Aug 6, 2024

a trivial rebase, back to positive review

@vbraun vbraun merged commit 8abb61c into sagemath:develop Aug 10, 2024
21 of 39 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide spkg-configure.m4 for msolve
4 participants