Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to support datastore specific migrations #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updates to support datastore specific migrations #89

wants to merge 2 commits into from

Conversation

phillipweston
Copy link

@phillipweston phillipweston commented Apr 19, 2019 •
edited
Loading

  • made the migration types functions return promises so we can Promise.all elsewhere
  • made it not require a callback

Phillip Weston added 2 commits April 19, 2019 01:44
update to auto-migrations. now return Promise.resolve() or Promise.re…
46f5cf4 
…ject(err), so that we can Promise.all on the separate migrations for each datastore.
updates to clean up code
eef3cbc
@phillipweston phillipweston mentioned this pull request Apr 19, 2019
Open
@phillipweston
Copy link
Author

I realize this is broken and that the whole thing needs to be under a single Waterline() instance. Attempted to do that, but had some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phillipweston