Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guava LoadingCache with Caffeine #55

Merged
merged 1 commit into from
May 9, 2024
Merged

Replace Guava LoadingCache with Caffeine #55

merged 1 commit into from
May 9, 2024

Conversation

yoikawa
Copy link
Contributor

@yoikawa yoikawa commented May 9, 2024

Replace Guava dependency with Caffeine

Subclass of GrammaticalLabelSetLoader should aware of method signature change from:

protected CacheBuilder<Object, Object> getCacheBuilder(LabelSetLoaderConfig config)

to:

protected Caffeine<Object, Object> getCacheBuilder(LabelSetLoaderConfig config)

@yoikawa yoikawa requested a review from ytanida May 9, 2024 04:19
@yoikawa yoikawa merged commit 337b463 into main May 9, 2024
4 checks passed
@yoikawa yoikawa deleted the replace-guava-with-caffeine branch May 9, 2024 04:45
yoikawa added a commit that referenced this pull request May 24, 2024
@yoikawa
fixed wrong refactoring of Caffeine migration in #55
5168a9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytanida ytanida ytanida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoikawa @ytanida