ICU-21301 bug fix #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytanida
approved these changes
May 22, 2024
yoikawa
commented
Jun 11, 2024
| @@ -833,8 +850,14 @@ public DateFormat getInputLongDateFormat() { | |||
| */ | |||
| public static DateFormat getLocaleInputDateFormat(Locale locale, TimeZone tz) { | |||
| DateFormat df = getFormatProvider(locale).getDateInstance(DateFormat.SHORT, locale); | |||
| // ICU-21301 hack: Apply only with an ICU object and when timezone has DST | |||
There was a problem hiding this comment.
according to ICU-21301, this only occurs when setLenient(boolean) is set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporally fix for ICU-21301: [ICU4J] SimpleDateFormatICU.parse method returns null if the given date is the start of DST.
When ICU is enabled, and if the desired time zone supports daylight saving time, parsing transition date fails. (e.g.
9/6/2020for"America/Santiago")If all conditions are met, create
java.text.SimipleDateFormatinstance instead ofSmipleDateFormatICUfor parsing date/time.