Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declensions returning null for singular form #61

Closed
wants to merge 1 commit into from

Conversation

yoikawa
Copy link
Contributor

@yoikawa yoikawa commented Sep 13, 2024

  • If RomanceNoun (used by French) has no singular form, Haitian declension derives no value and ends up returning null
    See fix in:

    • src/main/java/com/force/i18n/grammar/Adjective.java
    • src/main/java/com/force/i18n/grammar/ArticledDeclension.java
  • Refactor logging to normalize format/methods (through LogUtil). All error logs shows language

@yoikawa yoikawa closed this Sep 14, 2024
@yoikawa yoikawa deleted the fix-dictionary branch September 14, 2024 16:46
@yoikawa
Copy link
Contributor Author

yoikawa commented Sep 14, 2024

re-working it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant