fixed locale changes by JDK 17 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoikawa
commented
Dec 19, 2024
| */ | ||
| @Beta | ||
| @SuppressWarnings("rawtypes") // TODO Fix | ||
| public class IntHashMap<V> extends AbstractIntMap<V> implements Serializable { |
There was a problem hiding this comment.
remove redundant. implements Serializable is defined in the super class
yoikawa
commented
Dec 19, 2024
|
|
||
| /** | ||
| * The english articles are distinguished by whether the next noun starts with a vowel | ||
| * sound or not (although the, unlike a/an is spelled the same). | ||
| */ | ||
| public static enum EnglishArticleForm implements ArticleForm { |
There was a problem hiding this comment.
static is not necessary for enum
ytanida
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed
LabelUtils#getFileNames(HumanLanguage, URL, String)that failed to loadji,iw, andinsub-directory in JDK 17.Misc cleanup:
<>)staticforenumassertwith real check (e.g.checkStateorrequireNonNull)