Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd.run user, service params, stack registry auth, extension-fields, password in env var #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fraajad
Copy link
Contributor

@fraajad fraajad commented Jul 23, 2018

This PR adds several features, hopefully you will want them all! If separate PRs are preferred please let me know.

  1. Updates "user" to "runas" in cmd.run states to clear the deprecation warning.
  2. Flushes out docker.client.service with additional parameters.
  3. Adds --with-registry-auth to stack like service already has.
  4. Adds support for extension-fields templating to docker-compose.yml -- https://docs.docker.com/compose/compose-file/#extension-fields
  5. When a password is used in cmd.run it is sent as an environment variable so that it does not show up in the Salt minion logs.

…h-registry-auth in stack, support extension fields in compose file, pass credentials as env vars
Copy link
Member

@epcim epcim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, will test it first in mirantis gerrit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants