Add option to enable service #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epcim
reviewed
Sep 1, 2018
|
@epcim Good point, I've altered the PR to explicitly set the value of |
|
@epcim Is there anything else we can do to move this PR along? |
|
Is there anything blocking this PR? |
|
@BrianSidebotham can you please squash it to single commit? |
|
ok not needed any more, I managed and send to internal CI review. |
|
Is there any news on the review? Can I see the review status anywhere? |
|
Has this project died? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be no current way of enabling the nginx service optionally from a pillar ( See #42 ).
This PR adds a simple option to allow the service to be enabled (or not) through pillar data.