Add hba & servers settings control #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epcim
reviewed
Dec 28, 2017
| postgresql: | ||
| server: | ||
| ... | ||
| settings: |
There was a problem hiding this comment.
we don't do it this way for a good reason. Rather structure the settings under postresql:server pillar directly. That will make pillars readable, structured etc. The formula user should not recognize whether it's value for config file, etc..
I personally would agree with kind of "generic" ad-hoc way to add additional settings that formula don't support, but as we don't have any described procedure for that, it will not pass other reviewers.
epcim
requested changes
Dec 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI