formula-fetch: Allow MCP Gerrit, local fs git URI #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fetch formulas from Gerrit / local filesystem locations like: 1. FORMULA_SOURCES='https://gerrit.mcp.mirantis.com/salt-formulas ...' The Gerrit URI is constructed like: https://<gerrit host>/<gerrit project prefix for filtering> 2. FORMULA_SOURCES='file:///home/salt/formulas ...' To keep this change light, piggy-back on the fact that `hosting` is empty for 'file://<absolute path to formulas dir>'. To prevent fetching formula dependencies from github when fetching all formulas from MCP Gerrit, add basic support for dependency skip. Signed-off-by: Alexandru Avadanii <[email protected]>
alexandruavadanii
force-pushed
the
local-fs-git-formulas
branch
from
7dbb8d7 to
252ddc6
Compare
alexandruavadanii
changed the title
|
Hi, |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fetch formulas from locations like:
FORMULA_SOURCES='file:///home/salt/formulas http://github.com/...'
To keep this change light, piggy-back on the fact that
hostingisempty for 'file://'.