-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Add version param to pkg_params in _uninstall() #66714
Conversation
@Akm0d the failed in "CI / Arch Linux LTS Test / Test (zeromq, functional) (pull_request)" just caused by a PGP error when installing the package, it seems not relate to my patch, could you please re-run the test? thanks. |
@Akm0d the TEST still failed with "CI / Arch Linux LTS Test / Test (zeromq, functional) (pull_request)", the error followng:
It seems someone's PGP signature expired to caused the package install failed. |
@@ -2964,7 +2964,7 @@ def _uninstall( | |||
|
|||
try: | |||
pkg_params = __salt__["pkg_resource.parse_targets"]( | |||
name, pkgs, normalize=normalize | |||
name, pkgs, normalize=normalize, version=version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is fixed here: https://github.com/saltstack/salt/blob/3006.x/salt/states/pkg.py#L2887
Already added to 3006.x branch: #66810 |
What does this PR do?
Add "version" param to pkg_params from parse_targes() in _uninstall(), to check the pkg list after the specific version of the package removed.
What issues does this PR fix or reference?
Fixes: openSUSE/salt#658
Reference: 585145f
Reference: c0d2889
Need for PR: #66713
Previous Behavior
pkg_params only have the package name
New Behavior
pkg_params will include the package name:version
Commits signed with GPG?
Yes