Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add version param to pkg_params in _uninstall() #66714

Closed
wants to merge 2 commits into from

Conversation

winddss
Copy link

@winddss winddss commented Jul 15, 2024

What does this PR do?

Add "version" param to pkg_params from parse_targes() in _uninstall(), to check the pkg list after the specific version of the package removed.

What issues does this PR fix or reference?

Fixes: openSUSE/salt#658
Reference: 585145f
Reference: c0d2889

Need for PR: #66713

Previous Behavior

pkg_params only have the package name

New Behavior

pkg_params will include the package name:version

Commits signed with GPG?

Yes

@winddss winddss requested a review from a team as a code owner July 15, 2024 10:58
@winddss winddss requested a review from dwoz July 15, 2024 10:58
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add version param to pkg_params in _uninstall() [master] Add version param to pkg_params in _uninstall() Jul 15, 2024
@winddss
Copy link
Author

winddss commented Jul 17, 2024

@Akm0d the failed in "CI / Arch Linux LTS Test / Test (zeromq, functional) (pull_request)" just caused by a PGP error when installing the package, it seems not relate to my patch, could you please re-run the test? thanks.

@winddss
Copy link
Author

winddss commented Jul 18, 2024

@Akm0d the TEST still failed with "CI / Arch Linux LTS Test / Test (zeromq, functional) (pull_request)", the error followng:

Problem encountered installing package(s). Additional info follows:\n\nerrors:\n - Running as unit: run->ra20679281f924e8fa27aea22ab049893.scope; invocation ID: a4846cdc25f849a0ae6dfdf09a4c2ce0\n error: sl: >signature from "Brett Cornwall [email protected]" is unknown trust\n error: failed to commit transaction (invalid or >corrupted package (PGP signature))', 'sls': None, 'run_num': 0, 'start_time': '20:34:42.654470', 'duration': 1265.074, >'id': None}}, state_id='pkg_|-None_|-None_|-installed', full_return={'name': None, 'result': False, 'changes': {}, >'comment': 'Problem encountered installing package(s). Additional info follows:\n\nerrors:\n

It seems someone's PGP signature expired to caused the package install failed.

@winddss winddss requested a review from a team as a code owner August 22, 2024 18:00
@@ -2964,7 +2964,7 @@ def _uninstall(

try:
pkg_params = __salt__["pkg_resource.parse_targets"](
name, pkgs, normalize=normalize
name, pkgs, normalize=normalize, version=version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twangboy
Copy link
Contributor

Already added to 3006.x branch: #66810

@twangboy twangboy closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Zypperpkg does not use the version parameter
3 participants