Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sit.cephfs: Enable clustering for mgr variant #122

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

anoopcs9
Copy link
Collaborator

Clustering support is now natively available with ceph smb mgr module. Make use of clustering option to ceph.smb.cluster resource definition along with the placement count and required public addresses.

Clustering support is now available when configured using smb mgr
module. Let's enable clustering always for mgr module based setup.

Signed-off-by: Anoop C S <[email protected]>
This reverts commit b0e5af7.

Node ip address was only required for mgr variant in the absence of
clustering support.
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@anoopcs9
Copy link
Collaborator Author

Temporarily overriding GPFS CI results due to #123.

@anoopcs9 anoopcs9 merged commit 33037d6 into samba-in-kubernetes:main Sep 26, 2024
6 of 8 checks passed
@anoopcs9 anoopcs9 deleted the mgr-smb-enable-clustering branch September 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants