-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XFS backend #13
Merged
Merged
XFS backend #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
requested changes
Jul 26, 2023
Signed-off-by: Xavi Hernandez <[email protected]>
Some important tasks were executed by the gluster ansible collection, but we need to not depend on it to support other backends. This patch adds some tasks and makes some modifications that are required to successfully run ctdb and samba without using gluster related roles. Signed-off-by: Xavi Hernandez <[email protected]>
Signed-off-by: Xavi Hernandez <[email protected]>
retest this please |
anoopcs9
approved these changes
Jul 28, 2023
spuiuk
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an XFS backend to SITE. Some of the required tasks to make everything work were inside the gluster ansible colletion, so it has been needed to make some changes to common tasks besides adding the strictly necessary XFS-related things.