Normalize share and volume creation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
reviewed
Feb 22, 2024
xhernandez
force-pushed
the
shares
branch
2 times, most recently
from
489a073 to
eb8579d
Compare
anoopcs9
reviewed
Feb 28, 2024
Shwetha-Acharya
approved these changes
Feb 29, 2024
This patch normalizes the way shares and volumes are created. Till now, the volumes were created during installation of the backend, while shares were created during Samba installation. This caused some difficulties. Now the volume is created just before creating the share which seems more logical. Some differences between backends have also been removed so that it's more uniform. Signed-off-by: Xavi Hernandez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch normalizes the way shares and volumes are created. Till now, the volumes were created during installation of the backend, while shares were created during Samba installation. This caused some difficulties.
Now the volume is created just before creating the share which seems more logical. Some differences between backends have also been removed so that it's more uniform.
This need appeared as part of addressing the comments for #24.