Generate newer version of test-info.yml #96
Conversation
spuiuk
force-pushed
the
testinfo
branch
3 times, most recently
from
8de5eda to
6b67d05
Compare
Signed-off-by: Sachin Prabhu <[email protected]>
This isn't used in testing. Signed-off-by: Sachin Prabhu <[email protected]>
Use the new test-info.yml file as required by sit-test-cases. Signed-off-by: Sachin Prabhu <[email protected]>
Access to the backend filesystem is already provided through sshfs. Make sure that this is listed in test-info.yml allowing the testing infrastructure to prepare the backend for a test. Signed-off-by: Sachin Prabhu <[email protected]>
|
/retest all |
| - name: Create the test-info.yml file with test cluster information | ||
| template: | ||
| src: test-info.yml.j2 | ||
| dest: /root/test-info.yml |
There was a problem hiding this comment.
You could put it directly in /root/sit-test-cases/test-info.yml and avoid the symlink creation.
There was a problem hiding this comment.
I am trying to remember why I did it like this. I think I did it for re-use. ie. in case other testing projects wanted to make use of the information in that config file.
Another advantage is in a devel environment where we want to delete the whole sit-test-cases repo and redo the folder, it is easier if the configuration is outside the directory.
If it isn't too much of an issue, can we leave it as it is?
There was a problem hiding this comment.
Maybe it was a simple case of the repo being pulled after the test-info.yml file was created and hence the conf file wasn't created inside the repo . :) but the points above still hold.
There was a problem hiding this comment.
I am trying to remember why I did it like this. I think I did it for re-use. ie. in case other testing projects wanted to make use of the information in that config file.
The contents of the file are very sit-test-cases specific (that's why I suggested moving it inside the test.sit-test-cases role), so it's unlikely that it will be reused by other tests. Each test can create it's own custom configuration if required.
Another advantage is in a devel environment where we want to delete the whole sit-test-cases repo and redo the folder, it is easier if the configuration is outside the directory.
You still need to re-run the playbook to recreate the symlink. It's true that you can do it manually, though.
If it isn't too much of an issue, can we leave it as it is?
Yes, it's not a big problem, and it's contained all inside the test.sit-test-cases role, so if you prefer to keep it this way, I'm ok with that.
The new generation of tests in sit-test-cases require the use of the new version of test-info.yml files.
Changing the template to generate the new version of test-info.yml files.