Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fold testable example #45

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Conversation

taman9333
Copy link
Contributor

I just found that testable example for Fold function was in the wrong place & is not correct

@taman9333
Copy link
Contributor Author

@samber

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (1c2de46) to head (8ecf736).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files          15       15           
  Lines        1164     1164           
=======================================
  Hits         1034     1034           
  Misses        115      115           
  Partials       15       15           
Flag Coverage Δ
unittests 88.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@taman9333 taman9333 Jun 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore unused lint warning since those functions are used indirectly through the Fold function and
are necessary for implementing the Foldable interface. It seems that unused might not be smart enough to detect the interface implementation.

@samber
Copy link
Owner

samber commented Jun 23, 2024

@samber samber merged commit 028b1a0 into samber:master Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants