Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions: set flag "REDMINE_WAS_UPDATED" when a redmine-upgrade was done #565

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

SvenRoederer
Copy link
Contributor

For a custom plugin I need to know when the REDMINE-version was upgraded, to trigger some additional maintenance via entrypoint.custom.sh.
Setting the variable REDMINE_WAS_UPDATED=yes will allow my custom-entrypoint to detect such upgrade.

@jcormier
Copy link
Collaborator

This looks good. Were able to verify/test this exported variable is detectable in your script? Can you also verify if it can be used in the post-install.sh scripts?

@jcormier jcormier self-assigned this Aug 29, 2024
@jcormier jcormier self-requested a review August 29, 2024 18:51
@jcormier
Copy link
Collaborator

Also the README.md should be updated to document this

…done

Set the variable REDMINE_WAS_UPDATED=yes when the redmine-version was upgraded.
This flag can be evaluated later, e.g. inside entrypoint.custom.sh
@SvenRoederer
Copy link
Contributor Author

@jcormier I updated the commit to include a line inside Readme.

@jcormier jcormier merged commit d46d547 into sameersbn:master Sep 3, 2024
1 check passed
@jcormier
Copy link
Collaborator

jcormier commented Sep 3, 2024

Thanks this has been merged.

@SvenRoederer
Copy link
Contributor Author

Thanks for merging

@SvenRoederer
Copy link
Contributor Author

@jcormier can you cherry-pick into v5.0-stable branch?

@SvenRoederer SvenRoederer deleted the upgrade-flag branch September 4, 2024 11:19
@jcormier
Copy link
Collaborator

jcormier commented Sep 4, 2024

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants