Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major changes for consideration #20

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Conversation

jose-pr
Copy link

@jose-pr jose-pr commented Oct 23, 2023

A lot of changes to allow:

  • Choice of bind points, address, port, proto
  • Multiple upstream forwarders
  • Custom Resolver with helper resolvers such as a RoundRobinResolver
  • Partial support for DNSSEC queries to upstream nameservers
  • Configuration in multiple formats, json, toml, yaml
  • Attempt at better thread safety with ShareObject
  • Minor changes to dependencies to account for new features
  • Minor changes to pyproject to work with vcode pytests

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: Patch coverage is 72.70789% with 128 lines in your changes missing coverage. Please review.

Project coverage is 74.50%. Comparing base (a99dfe9) to head (eb48dba).

Files with missing lines Patch % Lines
dnserver/resolver.py 68.75% 31 Missing and 9 partials ⚠️
dnserver/dnssec.py 33.92% 35 Missing and 2 partials ⚠️
dnserver/main.py 75.38% 12 Missing and 20 partials ⚠️
dnserver/config.py 76.92% 10 Missing and 2 partials ⚠️
dnserver/common.py 92.47% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #20       +/-   ##
===========================================
- Coverage   97.54%   74.50%   -23.04%     
===========================================
  Files           4        8        +4     
  Lines         204      510      +306     
  Branches       37      122       +85     
===========================================
+ Hits          199      380      +181     
- Misses          3       93       +90     
- Partials        2       37       +35     
Files with missing lines Coverage Δ
dnserver/__init__.py 100.00% <100.00%> (ø)
dnserver/cli.py 94.73% <100.00%> (+0.14%) ⬆️
dnserver/common.py 92.47% <92.47%> (ø)
dnserver/config.py 76.92% <76.92%> (ø)
dnserver/main.py 76.29% <75.38%> (-22.83%) ⬇️
dnserver/dnssec.py 33.92% <33.92%> (ø)
dnserver/resolver.py 68.75% <68.75%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99dfe9...eb48dba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant