Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Make CreateRelationshipJob work for Valkyrie #908

Merged
merged 4 commits into from
Feb 2, 2024
Merged

🧹 Make CreateRelationshipJob work for Valkyrie #908

merged 4 commits into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. 🧹 Make the relationships job work for Valkyrie 

    This will add a relationships path for Valkyrie objects.  It also will
add a transactions call so set child flag will fire off in IIIF Print.

ref:
  - scientist-softserv/hykuup_knapsack#141
    @kirkkwang
    kirkkwang committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    08fd122 View commit details
    Browse the repository at this point in the history

  2. 💄 rubocop fix 

    Co-Authored-By: Kirk Wang <[email protected]>
    @ShanaLMoore @kirkkwang
    ShanaLMoore and kirkkwang committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    30021c9 View commit details
    Browse the repository at this point in the history

  3. ♻️ Adjust rescue logic to move closer to error 

    This also adds some consideration for refactoring the queries to instead
use the persistence layer.
    @jeremyf
    jeremyf committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    60aff98 View commit details
    Browse the repository at this point in the history

  4. Adding notes about transactions

    @jeremyf
    jeremyf committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f889c31 View commit details
    Browse the repository at this point in the history