Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Narrow specificity of CSS selector #2100

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Dec 21, 2023

The selector was very specific, and with the HTML class changes for
Bootstrap 3 to 4, this almost certainly broke.

Note, there are still underlying issues with two other specs; there
errors are listed below:

1) Admin can select home page theme when a search results theme is
selected updates the search results page with the selected layout view

Failure/Error: super

     ActionView::Template::Error:
       undefined method `with_collection' for nil:NilClass

The selector was *very* specific, and with the HTML class changes for
Bootstrap 3 to 4, this almost certainly broke.

Note, there are still underlying issues with two other specs; there
errors are listed below:

```
1) Admin can select home page theme when a search results theme is
selected updates the search results page with the selected layout view

Failure/Error: super

     ActionView::Template::Error:
       undefined method `with_collection' for nil:NilClass
```
The hyper specific selectors are not durable for CSS framework upgrades.
@jeremyf jeremyf force-pushed the hyrax-5-upgrade-fix-a-few-specs branch from 69533b5 to 9c3c46a Compare December 21, 2023 14:47
@jeremyf jeremyf merged commit 47648f1 into hyrax-5-upgrade Dec 21, 2023
1 of 3 checks passed
@jeremyf jeremyf deleted the hyrax-5-upgrade-fix-a-few-specs branch December 21, 2023 14:49
@jeremyf jeremyf restored the hyrax-5-upgrade-fix-a-few-specs branch December 21, 2023 15:35
@kirkkwang kirkkwang mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants