♻️ Account for observed customizations #2113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkkwang
reviewed
Dec 22, 2023
| # @return [String] the fully qualified URL. | ||
| # | ||
| # @example | ||
| # # The below example will build a URL taht will download directly from Hyrax as the |
There was a problem hiding this comment.
just a typo for the word that
jeremyf
force-pushed
the
hyrax-5-upgrade-refactor-for-pals
branch
2 times, most recently
from
91cb83e to
f88468c
Compare
kirkkwang
reviewed
Dec 22, 2023
|
|
||
| ## | ||
| # @!attribute iiif_video_labels_and_mime_types [r|w] | ||
| # @return [Hash<String,String>] Hash of valid vidoe labels and their mime types. |
kirkkwang
approved these changes
Dec 22, 2023
jeremyf
force-pushed
the
hyrax-5-upgrade-refactor-for-pals
branch
from
f88468c to
eb99895
Compare
Dear reviewer, put on your reading glasses. This commit looks at the newly refactored `Hyrax::IiifAv::DisplaysContentDecorator` as well as the current state of [PALS's Hyrax::IiifAv::DisplaysContentDecorator][1] and attempts to account for the variances between the two by introducing configurations. Yes, we could port this to the hyrax-iiif_av gem, but for now that would not solve the underlying issue of how we've been handling things. [1]: https://github.com/scientist-softserv/palni-palci/blob/8754556c0225ce9f04674c1ffac6403586fd65f4/app/presenters/concerns/hyrax/iiif_av/displays_content_decorator.rb
jeremyf
force-pushed
the
hyrax-5-upgrade-refactor-for-pals
branch
from
eb99895 to
b18a03b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear reviewer, put on your reading glasses.
This commit looks at the newly refactored
Hyrax::IiifAv::DisplaysContentDecoratoras well as the current state of PALS's Hyrax::IiifAv::DisplaysContentDecorator and attempts to account for the variances between the two by introducing configurations.Yes, we could port this to the hyrax-iiif_av gem, but for now that would not solve the underlying issue of how we've been handling things.