Prime hyrax 5 upgrade refactor for pals #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
prime-hyrax-5-upgrade-refactor-for-pals
branch
from
6261004
to
df49b98
Compare
kirkkwang
reviewed
Dec 22, 2023
| # @!attribute iiif_video_labels_and_mime_types [r|w] | ||
| # @see Hyrax::IiifAv::DisplaysContentDecorator | ||
| # @return [Hash<String,String>] Hash of valid video labels and their mime types. | ||
| class_attribute :iiif_video_labels_and_mime_types, default: { "mp4" => "video/mpeg", "webm" => "audio/webm" } |
There was a problem hiding this comment.
Does this need Hyrax::IiifAv::DisplaysContent in front of it?
There was a problem hiding this comment.
No. It's a Hyku::Application class attribute.
There was a problem hiding this comment.
I've been moving too quickly between two branches. I committed changes to reflect the correct state.
jeremyf
commented
Dec 22, 2023
jeremyf
commented
Dec 22, 2023
kirkkwang
reviewed
Dec 22, 2023
| # Hyrax::Engine.routes.url_helpers.download_url(document, host:, protocol: 'https') | ||
| # end | ||
| class_attribute :iiif_video_url_builder, | ||
| default: ->(document:, label:, host:) { Hyrax::IiifAv::Engine.routes.url_helpers.iiif_av_content_url(document.id, label:, host:) } |
There was a problem hiding this comment.
just a styling comment, this indent looks a little wonky
Dear reviewer, put on your reading glasses. This commit looks at the newly refactored `Hyrax::IiifAv::DisplaysContentDecorator` as well as the current state of [PALS's Hyrax::IiifAv::DisplaysContentDecorator][1] and attempts to account for the variances between the two by introducing configurations. Yes, we could port this to the hyrax-iiif_av gem, but for now that would not solve the underlying issue of how we've been handling things. Why the Hyku::Application class attribute? Because the decorator is being mixed into a module, which does not response to `.class_attribute` methods. [1]: https://github.com/scientist-softserv/palni-palci/blob/8754556c0225ce9f04674c1ffac6403586fd65f4/app/presenters/concerns/hyrax/iiif_av/displays_content_decorator.rb
jeremyf
force-pushed
the
prime-hyrax-5-upgrade-refactor-for-pals
branch
from
f72c7e9
to
87df9b0
Compare
|
Confirming that the failure also happens locally |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear reviewer, put on your reading glasses.
This commit looks at the newly refactored
Hyrax::IiifAv::DisplaysContentDecoratoras well as the current stateof PALS's Hyrax::IiifAv::DisplaysContentDecorator and attempts to
account for the variances between the two by introducing configurations.
Yes, we could port this to the hyrax-iiif_av gem, but for now that would
not solve the underlying issue of how we've been handling things.
Why the Hyku::Application class attribute? Because the decorator is
being mixed into a module, which does not response to
.class_attributemethods.