🧹 Comment out check for reports #2116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ady to the gem file and configure them
…amvera/hyku into mr_good_job_its_got_to_be_good
…mponent 🐛 Adding document_component to blacklight's config
Hyrax has :clean_repo and Hyku has :clean Sometimes folks copy over specs from Hyrax, and bring along the :clean_repo; which looks like it should work. With this commit, we bring that logic along!
Perhaps it's flappy; but let's see.
🧹 Allow :clean or :clean_repo to work for the cleaners
…for-collection-type 🧹 Remove skip CI
🧹 Fix button class for Bootstrap 3 to 4
Rubocop seams to prefer the Layout namespace for LineLength.
Checking the HTML (on the CircleCI SSH environment), it appears that the selector should work in test. But it is not. So I'm removing the specificity.
…deprecation 🧹 Favor Layout/LineLength over Metrics/LineLength
…ng-spec 🧹 The selector is not working
Prior to this commit, we did not automatically clean the features. The below ripgrep (and output) shows that there were some features which did not start from a clean state. ``` rg "(clean|clean_repo):" spec/features --files-without-match `` ``` spec/features/accounts_spec.rb spec/features/proprietor_spec.rb spec/features/featured_collections_spec.rb spec/features/user_roles_spec.rb spec/features/oai_pmh_spec.rb ```
…specs-run-clean 🧹 Ensure feature specs run clean
This commit will reconcile the services that are overrides for Hyrax with the Hyrax 5.0.0rc2 version. There were a number of overrides that were changed to the decorator pattern.
* adventist_dev: Appease rubocop clean up from pr review
This is not tested in the UI, but the `show_works_or_works_that_contain_files` remains after the troublesome advanced query filters.
Hyrax 5 upgrade with adventist dev
This commit addresses comments from the review but one thing that is of note is loading the I18n translations in the application.rb file. We needed this because our decorators load prior to I18n loads the locales in our config/locales directory for them to use so we were getting missing translations.
…hing 🧹 Attempting to find and squash bug
🧹 Clean up services
For this spec, if `Hyrax.config.analytics?` is enabled we need a legato user to query the analytics. Which creates a weird dependency that we may not want in this integration test. (This stuff is best tested in view tests; but here we are) I opted to not remove the spec but instead favor the `Hyrax.config.analytics?` which, if it is true likely means we have ENV vars that are in play.
|
Hey Jeremy, This one may be worth discussing. Kirk and I addressed the failing spec in another way. We had noticed that our local locale file was not taking precedence over the hyrax gem's version. Correcting that issue makes the spec pass. So is adding this conditional still worth while? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this spec, if
Hyrax.config.analytics?is enabled we need a legatouser to query the analytics. Which creates a weird dependency that we
may not want in this integration test.
(This stuff is best tested in view tests; but here we are)
I opted to not remove the spec but instead favor the
Hyrax.config.analytics?which, if it is true likely means we have ENVvars that are in play.