🧹 Update IIIF Print and AV gems #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not seeing images loading correctly in the UV because we introduced the `Hyku::WorksControllerBehavior` and IIIF Print did not know about it. - scientist-softserv/iiif_print@cad2cf3 We were seeing a respon to mismatch error in the Hyrax IIIF AV. - samvera-labs/hyrax-iiif_av@4723b8f Also, the image that I tested was a phone image that apparently had different ExifImageHeight/ExifImageWidth values than the ImageHeight/ImageWidth values. This was probably because modern phones typically generate multiple images so the user can choose the best shot. The exiftool_image_to_fits.xslt was proritizing the Exif values over the regular values and would cause our image characterization to have weird height and width values. The change in this PR prioritizes the regular over the Exif values. Ref: - scientist-softserv/hykuup_knapsack#68
kirkkwang
commented
Jan 2, 2024
| </xsl:otherwise> | ||
| </xsl:choose> | ||
| </compressionScheme> | ||
| </xsl:if> | ||
| <imageWidth> | ||
| <xsl:choose> | ||
| <xsl:when test="exiftool/ExifImageWidth"> |
There was a problem hiding this comment.
Meaningful change starts here, everything else is removing spaces
kirkkwang
commented
Jan 2, 2024
| </xsl:when> | ||
| <xsl:otherwise> | ||
| <xsl:value-of select="exiftool/ImageHeight[1]"/> | ||
| <xsl:value-of select="exiftool/ExifImageHeight[1]"/> |
There was a problem hiding this comment.
Meaningful change ends here
ShanaLMoore
approved these changes
Jan 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not seeing images loading correctly in the UV because we introduced the
Hyku::WorksControllerBehaviorand IIIF Print did not know about it.We were seeing a respon to mismatch error in the Hyrax IIIF AV.
Also, the image that I tested was a phone image that apparently had different ExifImageHeight/ExifImageWidth values than the ImageHeight/ImageWidth values. This was probably because modern phones typically generate multiple images so the user can choose the best shot. The exiftool_image_to_fits.xslt was proritizing the Exif values over the regular values and would cause our image characterization to have weird height and width values. The change in this PR prioritizes the regular over the Exif values.
Ref: