Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix video thumbnail generation #2120

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

kirkkwang
Copy link
Collaborator

In a previous commit we created the
Hyrax::FileSetDerivativesServiceDecorator to override the default thumbnails that Hyrax uses but I forgot to add the video thumbnail, which is fixed here.

Ref

image

In a previous commit we created the
`Hyrax::FileSetDerivativesServiceDecorator` to override the default
thumbnails that Hyrax uses but I forgot to add the video thumbnail,
which is fixed here.

Ref
  - scientist-softserv/hykuup_knapsack#69
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 2, 2024
@kirkkwang kirkkwang merged commit a8d190b into hyrax-5-upgrade Jan 2, 2024
3 of 4 checks passed
@kirkkwang kirkkwang deleted the hyrax-5-fix-video-thumbnail branch January 2, 2024 21:47
@kirkkwang kirkkwang mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants