Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎁 Depositor notifications #2226

Merged
merged 11 commits into from
May 31, 2024
Merged

🎁 Depositor notifications #2226

merged 11 commits into from
May 31, 2024

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented May 29, 2024 •
edited
Loading

Issue:

TODO:

  • make email dynamic, including the date, tenant name, link to dashboard, etc
  • Do we want to make an option for the user to not receive emails? If so - we need UI work and possibly migrations. [update - this is now in the SOW and needs to be a separate ticket/work]
  • How often Hyrax::UserStatImporter job run? - Is Rob setting up a job to run the rake task. Task needs to work for all tenants. [ update - not sure this matters for our sake ]
  • specs

image

@ShanaLMoore ShanaLMoore added the patch-ver for release notes label May 29, 2024
@ShanaLMoore ShanaLMoore force-pushed the i1020-depositor-email-notifications branch 2 times, most recently from a54f481 to 9898968 Compare May 29, 2024 22:17
@ShanaLMoore
🚧 WIP - Author notifications
a332d87 
boilerplate is WIP. template with sample email has been created at this point but needs to be dynamic.

TODO:
- understand UserStats and replace placeholder data
- make email dynamic, including the date, tenant name, link to dashboard, etc
- Do we want to make an option for the user to not receive emails? If so - we need UI work and possibly migrations.
- specs
@ShanaLMoore ShanaLMoore force-pushed the i1020-depositor-email-notifications branch from 9898968 to a332d87 Compare May 29, 2024 22:20
@ShanaLMoore
🧹 make depositor email dynamic
0bffe8e 
TODO: make stats dynamic
@ShanaLMoore ShanaLMoore force-pushed the i1020-depositor-email-notifications branch from 4e4e6f8 to 0bffe8e Compare May 29, 2024 22:53
@laritakr laritakr marked this pull request as ready for review May 31, 2024 20:06
@ShanaLMoore
Copy link
Collaborator Author

ShanaLMoore commented May 31, 2024 •
edited
Loading

@laritakr @kirkkwang I can't approve this since I opened it, but it looks good! Thanks so much for completing this.

kirkkwang
kirkkwang previously approved these changes May 31, 2024
View reviewed changes
@ShanaLMoore ShanaLMoore changed the title 🚧 WIP - Author notifications 🎁 Author notifications May 31, 2024
kirkkwang
kirkkwang previously approved these changes May 31, 2024
View reviewed changes
@laritakr laritakr merged commit 4f746c9 into main May 31, 2024
4 checks passed
@laritakr laritakr deleted the i1020-depositor-email-notifications branch May 31, 2024 21:02
@ShanaLMoore ShanaLMoore changed the title 🎁 Author notifications 🎁 Depositor notifications Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkkwang kirkkwang kirkkwang approved these changes

Assignees
No one assigned
Labels
patch-ver for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShanaLMoore @kirkkwang @laritakr