🧹 [i1020] - ga4 follow up

[ShanaLMoore]

Summary

This contains the following work needed to support google analytics:

• update Hyrax to pull in typo changes that prevented download tracking
  • [i1020] - correct ga4 typo that prevents download tracking hyrax#6897
• add fallback for when application name is blank
• don't send email if 0 new counts
• all download buttons needs 'file_download' as id for tracking
  • missing from:

Issue:

• Implement Depositor Notifications scientist-softserv/palni-palci#1020

TODO:

• update palni palci knapsack's submodule after this gets merged

Notes

change download-pdf-button => file_download

54168b7

ID must be changed so to be consistent with google analytics tracking.

Issue:

• Implement Depositor Notifications scientist-softserv/palni-palci#1020

Add fallback for when application_name is nil

fd8bdb7

This should avoid sending emails with blank names in the title.

Skip if new_work_views or new_file_downloads is 0

608faf9

update hyrax

7c39215

pulls in ga4 typo fix

• [i1020] - correct ga4 typo that prevents download tracking hyrax#6897

[github-actions]

Test Results

    3 files  ±0      3 suites  ±0   17m 40s ⏱️ +6s
2 034 tests +1  1 984 ✅ +3  50 💤 ±0  0 ❌  - 2 
2 061 runs  +1  2 009 ✅ +3  52 💤 ±0  0 ❌  - 2 

Results for commit 98a3d55. ± Comparison against base commit f09b786.

This pull request removes 42 and adds 43 tests. Note that renamed tests count towards both.

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy e6f3fdc4-cf17-45ff-8b0d-279342801c1b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit b24c2c12-c7fb-4899-b135-84a14c912803
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 7abe1f50-9df9-4fb6-82ba-923971483f0e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 023f6b01-cabf-4e77-be38-bbdca4bd1c14
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 566ecdbf-7db0-4b16-8e41-5097ce21de36
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit bb736a5f-aafe-4bd9-a4ad-7360d272a8ee
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ef9e1bb7-049a-41a9-8da3-cc032ca99a1d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c68cc6fd-2023-409d-a324-3366ade299d6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 076e9704-70c2-4306-ba0b-1b6008a30da1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit cc104e2f-d1e4-43a9-8421-f68ff91169b9
…

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 83d4e082-9ff6-4f73-bd95-057ba4d98eaf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit c269dd66-2e0c-434f-89b3-24f5d8b62272
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read eea333ab-948e-4535-8492-03336f49e03f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update e6780b9b-5f94-4d57-bea0-9a6956616ea4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy ebdf0be7-c81b-4510-9386-5de39636e03e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 37adb3d5-2fb9-4ab0-b9e0-efaa9ba884c7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 12a71693-6400-4606-a0f6-c651d9a5a6f1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c5e06607-c63b-46a9-9bb5-aa8af7ca108a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 0fca594e-5601-469d-9125-e450d34c10a4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 4282fa0c-688d-43d1-a751-b27f3be75fc0
…

♻️ This comment has been updated with latest results.