-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent field mappings set value from bleeding into other specs #2391
Conversation
Test Results 3 files ±0 3 suites ±0 18m 26s ⏱️ +3s Results for commit cda7724. ± Comparison against base commit 36c6aab. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding the solution so quickly! :)
Since
Hyku.default_bulkrax_field_mappings=
sets an instance variable, it can persist in scope for other specs, causing unexpected / flaky failures