Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent field mappings set value from bleeding into other specs #2391

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

bkiahstroud
Copy link
Collaborator

@bkiahstroud bkiahstroud commented Nov 26, 2024

Since Hyku.default_bulkrax_field_mappings= sets an instance variable, it can persist in scope for other specs, causing unexpected / flaky failures

Copy link

github-actions bot commented Nov 26, 2024

Test Results

    3 files  ±0      3 suites  ±0   18m 26s ⏱️ +3s
2 053 tests ±0  2 003 ✅ +1  50 💤 ±0  0 ❌  - 1 
2 080 runs  ±0  2 028 ✅ +1  52 💤 ±0  0 ❌  - 1 

Results for commit cda7724. ± Comparison against base commit 36c6aab.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b9573ca3-0480-48e3-8080-45950deb23e8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit c3ccda88-0321-429e-86eb-701527812efb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read e5844b6c-960e-4ab3-9848-48f14b9b1fff
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 6c1ff9e4-bd58-46fe-b36a-ae580e021df8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy dd09fcd5-67c4-421d-a492-2351a23d1e22
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 1e11317c-e4bc-4e67-bd11-03f1b8245db6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 1cff900b-d747-44a9-a935-5eab031e59b6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 879fc6ab-fa45-4f8f-9f73-250b4139123e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 72d30ebb-dfe6-40b7-b021-33211c0f249d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 18338ffa-e7f8-4df5-afbf-6c29eeda3a54
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 87a67164-3576-4f70-b76d-ffd2b1915fb2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit b599c1fc-a8a6-4d9f-b223-c10a4e03ebf2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 041091e2-e8b0-4645-8fcc-fe6cce05d8d9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update de8136fa-3e30-4178-8f4f-d1e8fde6fd0c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 8491c81c-ea06-41c0-95cb-7aeb61de4d1d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f411f7a6-db6e-44ec-a8e9-3cdee067ec64
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read a09825d4-8517-4e0d-b563-bc7961f564c9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 93a1d5dd-aa39-4939-9e23-8ad4fa412eaf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 01247f51-bc90-461c-b9ca-b49d2b68d233
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit c608f019-60f3-4fe5-a05c-1e296f1087e2
…

♻️ This comment has been updated with latest results.

@bkiahstroud bkiahstroud marked this pull request as ready for review November 26, 2024 19:20
@bkiahstroud bkiahstroud added the patch-ver for release notes label Nov 26, 2024
Copy link
Collaborator

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the solution so quickly! :)

@bkiahstroud bkiahstroud merged commit d427e24 into main Nov 26, 2024
8 of 9 checks passed
@bkiahstroud bkiahstroud deleted the fix-field-mappings-spec branch November 26, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants