Fix incorrectly colored save button

[sephirothkod]

Simpleform injects css classes into its button tags and those classes conflict with what is used in Hyku. The forms on the Pages page were using the button tag instead of the submit tag and causing the classes to be duplicated and conflict with each other. By using the submit tag it doesn't inject classes and only applies the classes specified in the tag.

Button color for "Save changes" button was white instead of blue like the rest of Hyku. This fixes that issue as well as issues in the future stemming from this "class injection".

@samvera/hyku-code-reviewers

[github-actions]

Test Results

    3 files  ±0      3 suites  ±0   18m 4s ⏱️ +7s
2 053 tests ±0  2 003 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 080 runs  ±0  2 028 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit 5d48741. ± Comparison against base commit f76a5d5.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 77435634-9f8a-4df5-b52a-640a706aab69
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit cc718ba4-1958-499c-b948-1313ebb5dab9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 88a4c3a2-26da-4610-b74d-c351fd8ee64b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update c053bd4f-991b-4ec9-981c-8fd1076e3f4a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy bf1206b2-4a11-4851-9251-525c94f6a5e7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 2150fe91-65be-4f84-be1b-d672261d506b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 6bca7913-538c-4f66-973b-f9c0a62e4da2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 3aaff1b3-1060-4ece-b98e-0c50428811cf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 8ff865c6-c83d-42ff-a9f2-a189c221aac3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit e90a89e4-252b-4ddf-b5f2-f1efaee9c3f8
…

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 91543811-03af-4668-9e13-79c0f9cfe90a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit ddb19219-61ea-4a35-83d7-be9c346c0fda
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read cbeb9572-40bd-441d-9de2-6adb311a6d29
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 3c41fde3-5312-4eb7-a65b-d456f89b670c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy c854a9ce-3f57-477e-9676-aa36b61fcc89
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit dde1fd10-b2f7-4277-996a-f260dc960e58
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read d1c3a172-09d0-4a51-a960-5e6e17e1b3d6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 49594b50-f234-45aa-911d-a05adcb75564
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 49f901af-d0d0-4d37-a2b3-8c0e6defbc9d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 7870b04b-19aa-4ab2-906e-45ee92a0bc41
…

♻️ This comment has been updated with latest results.

[bkiahstroud]

Thanks for the PR!

The way you've described the issue makes me wonder if this is happening elsewhere in Hyku as well... if the fundamental issue is a conflict between Hyku theming and simpleform, I think changing the class names Hyku uses would make more sense. Would something like prefixing the classes Hyku uses with hyku_ be enough to prevent the conflict?

[sephirothkod]

Thanks for the PR!

The way you've described the issue makes me wonder if this is happening elsewhere in Hyku as well... if the fundamental issue is a conflict between Hyku theming and simpleform, I think changing the class names Hyku uses would make more sense. Would something like prefixing the classes Hyku uses with hyku_ be enough to prevent the conflict?

The classes that I am referring to are the bootstrap classes so it is part of a library that we can't really change.